-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multi-line node block in Visual Editor #2005
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeze322
changed the title
draft: support resizable node in Visual Editor
draft: support multiline text in Visual Editor
Feb 19, 2020
yeze322
changed the title
draft: support multiline text in Visual Editor
feat: implement size sensitive node block in Visual Editor
Feb 20, 2020
yeze322
changed the title
feat: implement size sensitive node block in Visual Editor
feat: implement size-sensitive node block in Visual Editor
Feb 20, 2020
yeze322
force-pushed
the
visual/dynamic-layout
branch
from
February 20, 2020 16:40
a54b335
to
6eb4fde
Compare
yeze322
force-pushed
the
visual/dynamic-layout
branch
from
February 21, 2020 10:17
1432101
to
fefd425
Compare
yeze322
force-pushed
the
visual/dynamic-layout
branch
from
February 21, 2020 11:38
9af7281
to
a0c7c94
Compare
yeze322
changed the title
feat: implement size-sensitive node block in Visual Editor
feat: support multi-line node block in Visual Editor
Feb 24, 2020
a-b-r-o-w-n
reviewed
Feb 24, 2020
Composer/packages/extensions/visual-designer/src/components/nodes/templates/FormCard.tsx
Outdated
Show resolved
Hide resolved
5 tasks
a-b-r-o-w-n
approved these changes
Feb 25, 2020
Is there a limit to the vertical/horizontal growth potential of a node? It
shouldn’t be unbounded.
…On Tue, Feb 25, 2020 at 2:19 PM Andy Brown ***@***.***> wrote:
Merged #2005
<#2005> into
master.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#2005?email_source=notifications&email_token=AAI2MYFT4AVXPB5TH2XRIXDREWKPVA5CNFSM4KXG7IO2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOW4HWJNY#event-3071239351>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI2MYDDGR2XDJ2GTXZW7DDREWKPVANCNFSM4KXG7IOQ>
.
|
@cwhitten No there isn't. Maybe we can add a |
Yes that sounds like a good idea. And we may need to truncate text on the
final line when we hit that boundary. Thoughts?
…On Tue, Feb 25, 2020 at 6:59 PM zeye ***@***.***> wrote:
@cwhitten <https://github.com/cwhitten> No there isn't. Maybe we can add
a max-height css property to limit the bounds?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2005?email_source=notifications&email_token=AAI2MYBOFIC2VGRU54PI7ODREXLIBA5CNFSM4KXG7IO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM6TCCA#issuecomment-591212808>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI2MYBDXWDEE63SYHBLS5LREXLIBANCNFSM4KXG7IOQ>
.
|
@cwhitten that's right, let me update some css |
7 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #1701
Make the node block size-sensitive in Visual Editor: action flow's layout will change along with a single node block's size automatically.
(leverages the react-measure lib as a new dependency)
More Context
Why we need this functionality?
In new action design, some $types have dynamic sizes. For example, when the prompt content inside a SendActivity node becomes very long, the node will have 2 or more lines to show full content.
This is a challenge to our layouter, we need to make the layout size-sensitive.
How it works?
onResize
event whenever its DOM size changes;onResize
chain;What's changed?
FormCard
to make basic node blocks can show multiline textonResize
chain), it had been outdated for a whileuseSmartLayout
, used to observe node sizes and recompute new layout when neededStepGroup
,IfCondition
,SwitchCondition
,Foreach
,Prompt
to the new hook to make them size-sensitiveDesignerCache
class for caching calculated node sizesWhat's next?
Task Item
#1701
Screenshots